linux-kernel - Re: [PATCH] ext4: set error return correctly when ext4_htree_store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Aug 2019 16:36:05 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Colin King <colin.king@...onical.com>
Cc:     Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: set error return correctly when
 ext4_htree_store_dirent fails

On Mon, Aug 05, 2019 at 11:44:19PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently when the call to ext4_htree_store_dirent fails the error return
> variable 'ret' is is not being set to the error code and variable count is
> instead, hence the error code is not being returned.  Fix this by assigning
> ret to the error return code.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: 8af0f0822797 ("ext4: fix readdir error in the case of inline_data+dir_index")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.

					- Ted