[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20190812.140244.1191094093267734606.davem@davemloft.net>
Date: Mon, 12 Aug 2019 14:02:44 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: git@...red.net
Cc: linux-kernel@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com,
hkallweit1@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: phy: at803x: stop switching phy delay config
needlessly
From: André Draszik <git@...red.net>
Date: Fri, 9 Aug 2019 12:20:25 +0100
> This driver does a funny dance disabling and re-enabling
> RX and/or TX delays. In any of the RGMII-ID modes, it first
> disables the delays, just to re-enable them again right
> away. This looks like a needless exercise.
>
> Just enable the respective delays when in any of the
> relevant 'id' modes, and disable them otherwise.
>
> Also, remove comments which don't add anything that can't be
> seen by looking at the code.
>
> Signed-off-by: André Draszik <git@...red.net>
Applied.
Powered by blists - more mailing lists