linux-kernel - Re: [PATCH] rtc: mxc: use spin_lock_irqsave instead of spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190812210442.GV3600@piout.net>
Date:   Mon, 12 Aug 2019 23:04:42 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: mxc: use spin_lock_irqsave instead of spin_lock_irq
 in IRQ context

On 07/08/2019 16:23:10+0800, Fuqian Huang wrote:
> As spin_unlock_irq will enable interrupts.
> mxc_rtc_irq_enable is called from interrupt handler mxc_rtc_interrupt.
> Interrupts are enabled in interrupt handler.
> Use spin_lock_irqsave/spin_unlock_irqrestore instead of spin_(un)lock_irq
> in IRQ context to avoid this.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> ---
>  drivers/rtc/rtc-mxc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com