linux-kernel - Re: [PATCH v2 02/24] EDAC, ghes: Fix grain calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190812073221.GA23772@zn.tnic>
Date:   Mon, 12 Aug 2019 09:32:22 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Robert Richter <rrichter@...vell.com>
Cc:     James Morse <james.morse@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 02/24] EDAC, ghes: Fix grain calculation

On Mon, Aug 12, 2019 at 06:42:00AM +0000, Robert Richter wrote:
> I have seen you had actively promoted this style guideline, I even was
> not aware of it, thanks for the pointer.

It is about time we started writing proper commit messages. How long are
we trying, 20 years...?

> With the grain_bits calculation the mask is rounded up to the next
> power of 2 value.

mask	  = 0xffffffffff00ff00
~mask	  = 0x0000000000ff00ff
~mask + 1 = 0x0000000000ff0100

Your "trick" of adding a 1 to get to the most significant bit simply
doesn't work here. Thus:

"I guess we can leave it like that for now until some "inventive"
firmware actually does it."

> The reason this is here is because this check will be moved to
> edac_raw_mc_handle_error() to unify edac_mc and ghes code (see patch
> #4).

Ok.

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.