linux-kernel - Re: [PATCH v3] perf diff: Report noisy for cycles diff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190812083555.GC11752@krava>
Date:   Mon, 12 Aug 2019 10:35:55 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v3] perf diff: Report noisy for cycles diff

On Sat, Aug 10, 2019 at 07:30:29AM +0800, Jin Yao wrote:

SNIP

> +		if (vals[i] != 0)
> +			return 0;
> +	return 1;
> +}
> +
> +static int print_cycles_spark(char *bf, int size, unsigned long *svals, u64 n)
> +{
> +	int len = n, printed;
> +
> +	if (len <= 1)
> +		return 0;
> +
> +	if (len > NUM_SPARKS)
> +		len = NUM_SPARKS;
> +	if (all_zero(svals, len))
> +		return 0;
> +
> +	printed = print_spark(bf, size, svals, len);
> +	printed += scnprintf(bf + printed, size - printed, " ");
> +
> +	if (n > NUM_SPARKS)
> +		printed += scnprintf(bf + printed, size - printed, "..");

will this '..' ever be printed? I can't see that even if I enlarge
the column width..

jirka