linux-kernel - Re: [PATCH] xen/blkback: fix memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9e38eba-b638-a1b5-e42b-9f72a5218264@oracle.com>
Date:   Mon, 12 Aug 2019 08:41:17 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Wenwen Wang <wenwen@...uga.edu>
Cc:     Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Roger Pau Monné <roger.pau@...rix.com>,
        Jens Axboe <axboe@...nel.dk>,
        "moderated list:XEN BLOCK SUBSYSTEM" <xen-devel@...ts.xenproject.org>,
        "open list:BLOCK LAYER" <linux-block@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen/blkback: fix memory leaks

On 8/11/19 1:23 PM, Wenwen Wang wrote:
> In read_per_ring_refs(), after 'req' and related memory regions are
> allocated, xen_blkif_map() is invoked to map the shared frame, irq, and
> etc. However, if this mapping process fails, no cleanup is performed,
> leading to memory leaks. To fix this issue, invoke the cleanup before
> returning the error.


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>