[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <611fe8c6-f907-d022-3484-ff53b2bd4331@roeck-us.net>
Date: Mon, 12 Aug 2019 06:30:10 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Anson.Huang@....com, wim@...ux-watchdog.org, shawnguo@...nel.org,
s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
linux-watchdog@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: Linux-imx@....com
Subject: Re: [PATCH] watchdog: imx_sc: Remove unnecessary error log
On 8/12/19 1:44 AM, Anson.Huang@....com wrote:
> From: Anson Huang <Anson.Huang@....com>
>
> An error message is already displayed by watchdog_register_device()
> when failed, so no need to have error log again for failure of
> calling devm_watchdog_register_device().
>
> Signed-off-by: Anson Huang <Anson.Huang@....com>
Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> ---
> drivers/watchdog/imx_sc_wdt.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/watchdog/imx_sc_wdt.c b/drivers/watchdog/imx_sc_wdt.c
> index 78eaaf7..9260475 100644
> --- a/drivers/watchdog/imx_sc_wdt.c
> +++ b/drivers/watchdog/imx_sc_wdt.c
> @@ -175,11 +175,8 @@ static int imx_sc_wdt_probe(struct platform_device *pdev)
> watchdog_stop_on_unregister(wdog);
>
> ret = devm_watchdog_register_device(dev, wdog);
> -
> - if (ret) {
> - dev_err(dev, "Failed to register watchdog device\n");
> + if (ret)
> return ret;
> - }
>
> ret = imx_scu_irq_group_enable(SC_IRQ_GROUP_WDOG,
> SC_IRQ_WDOG,
>
Powered by blists - more mailing lists