linux-kernel - Re: [Non-DoD Source] Re: [PATCH] fanotify, inotify, dnotify, security: add security hook for fs notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f03baf3a-d688-b949-09e3-5c2beb2f6f07@tycho.nsa.gov>
Date:   Mon, 12 Aug 2019 09:49:51 -0400
From:   Aaron Goidel <acgoide@...ho.nsa.gov>
To:     Jan Kara <jack@...e.cz>, Paul Moore <paul@...l-moore.com>
Cc:     Amir Goldstein <amir73il@...il.com>, selinux@...r.kernel.org,
        LSM List <linux-security-module@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        David Howells <dhowells@...hat.com>,
        James Morris <jmorris@...ei.org>,
        Stephen Smalley <sds@...ho.nsa.gov>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Non-DoD Source] Re: [PATCH] fanotify, inotify, dnotify,
 security: add security hook for fs notifications

On 8/12/19 9:41 AM, Jan Kara wrote:
> On Sat 10-08-19 11:01:16, Paul Moore wrote:
>> On August 10, 2019 6:05:27 AM Amir Goldstein <amir73il@...il.com> wrote:
>>
>>>>>> Other than Casey's comments, and ACK, I'm not seeing much commentary
>>>>>> on this patch so FS and LSM folks consider this your last chance - if
>>>>>> I don't hear any objections by the end of this week I'll plan on
>>>>>> merging this into selinux/next next week.
>>>>>
>>>>> Please consider it is summer time so people may be on vacation like I was...
>>>>
>>>> This is one of the reasons why I was speaking to the mailing list and
>>>> not a particular individual :)
>>>
>>> Jan is fsnotify maintainer, so I think you should wait for an explicit ACK
>>> from Jan or just merge the hook definition and ask Jan to merge to
>>> fsnotify security hooks.
>>
>> Aaron posted his first patch a month ago in the beginning of July and I
>> don't recall seeing any comments from Jan on any of the patch revisions.
>> I would feel much better with an ACK/Reviewed-by from Jan, or you - which
>> is why I sent that email - but I'm not going to wait forever and I'd like
>> to get this into -next soon so we can get some testing.
> 
> Yeah, sorry for the delays. I'm aware of the patch but I was also on
> vacation and pretty busy at work so Amir always beat me in commenting on
> the patch and I didn't have much to add. Once Aaron fixes the latest
> comments from Amir, I'll give the patch the final look and give my ack.
> 
> 								Honza
> 

I already re-spun the patch with the changes Amir and I agreed to. There 
was an email with the PATCH v2. It may have flown under the radar a bit, 
so just wanted to point that out.
-- 
Aaron