linux-kernel - Re: [PATCH] dpaa2-ethsw: move the DPAA2 Ethernet Switch driver out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190812135746.GL14290@lunn.ch>
Date:   Mon, 12 Aug 2019 15:57:46 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
Subject: Re: [PATCH] dpaa2-ethsw: move the DPAA2 Ethernet Switch driver out
 of staging

> In the DPAA2 architecture MACs are not the only entities that can be 
> connected to a switch port.
> Below is an exemple of a 4 port DPAA2 switch which is configured to 
> interconnect 2 DPNIs (network interfaces) and 2 DPMACs.
> 
> 
>   [ethA]     [ethB]     [ethC]     [ethD]     [ethE]     [ethF]
>      :          :          :          :          :          :
>      :          :          :          :          :          :
> [eth drv]  [eth drv]  [                ethsw drv              ]
>      :          :          :          :          :          :        kernel
> ========================================================================
>      :          :          :          :          :          : 
> hardware
>   [DPNI]      [DPNI]     [============= DPSW =================]
>      |          |          |          |          |          |
>      |           ----------           |       [DPMAC]    [DPMAC]
>       -------------------------------            |          |
>                                                  |          |
>                                                [PHY]      [PHY]
> 
> You can see it as a hardware-accelerated software bridge where
> forwarding rules are managed from the host software partition.

Hi Ioana

What are the use cases for this?

Configuration is rather unintuitive. To bridge etha and ethb you need
to

ip link add name br0 type bridge
ip link set ethc master br0
ip link set ethd master br0

And once you make ethc and ethd actually send/receive frames, etha and
ethc become equivalent.

If this was a PCI device, i could imagine passing etha into a VM as a
PCI VF. But i don't think it is PCI?

I'm not sure moving etha into a different name space makes much sense
either. My guess would be, a veth pair with one end connected to the
software bridge would be more efficient than DMAing the packet out and
then back in again.

     Thanks
	Andrew