linux-kernel - Re: [PATCH 1/2] riscv: Add memmove string operation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Aug 2019 08:04:46 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Nick Hu <nickhu@...estech.com>
Cc:     alankao@...estech.com, paul.walmsley@...ive.com, palmer@...ive.com,
        aou@...s.berkeley.edu, green.hu@...il.com, deanbo422@...il.com,
        tglx@...utronix.de, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, aryabinin@...tuozzo.com,
        glider@...gle.com, dvyukov@...gle.com, Anup.Patel@....com,
        gregkh@...uxfoundation.org, alexios.zavras@...el.com,
        atish.patra@....com, zong@...estech.com, kasan-dev@...glegroups.com
Subject: Re: [PATCH 1/2] riscv: Add memmove string operation.

On Wed, Aug 07, 2019 at 03:19:14PM +0800, Nick Hu wrote:
> There are some features which need this string operation for compilation,
> like KASAN. So the purpose of this porting is for the features like KASAN
> which cannot be compiled without it.
> 
> KASAN's string operations would replace the original string operations and
> call for the architecture defined string operations. Since we don't have
> this in current kernel, this patch provides the implementation.
> 
> This porting refers to the 'arch/nds32/lib/memmove.S'.

This looks sensible to me, although my stringop asm is rather rusty,
so just an ack and not a real review-by:

Acked-by: Christoph Hellwig <hch@....de>