linux-kernel - Re: [PATCH] ARM: ep93xx: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Aug 2019 18:30:57 +0200
From:   Alexander Sverdlin <alexander.sverdlin@...il.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Hartley Sweeten <hsweeten@...ionengravers.com>,
        Russell King <linux@...linux.org.uk>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: ep93xx: Mark expected switch fall-through

Hi!

On 08/08/2019 04:38, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
> 
> Fix the following warnings (Building: arm-ep93xx_defconfig arm):
> 
> arch/arm/mach-ep93xx/crunch.c: In function 'crunch_do':
> arch/arm/mach-ep93xx/crunch.c:46:3: warning: this statement may
> fall through [-Wimplicit-fallthrough=]
>        memset(crunch_state, 0, sizeof(*crunch_state));
>        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     arch/arm/mach-ep93xx/crunch.c:53:2: note: here
>       case THREAD_NOTIFY_EXIT:
>       ^~~~
> 
> Notice that, in this particular case, the code comment is
> modified in accordance with what GCC is expecting to find.
> 
> Reported-by: kbuild test robot <lkp@...el.com>

Acked-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>   arch/arm/mach-ep93xx/crunch.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-ep93xx/crunch.c b/arch/arm/mach-ep93xx/crunch.c
> index 1c9a4be8b503..1c05c5bf7e5c 100644
> --- a/arch/arm/mach-ep93xx/crunch.c
> +++ b/arch/arm/mach-ep93xx/crunch.c
> @@ -49,6 +49,7 @@ static int crunch_do(struct notifier_block *self, unsigned long cmd, void *t)
>   		 * FALLTHROUGH: Ensure we don't try to overwrite our newly
>   		 * initialised state information on the first fault.
>   		 */
> +		/* Fall through */
>   
>   	case THREAD_NOTIFY_EXIT:
>   		crunch_task_release(thread);
>