linux-kernel - Re: linux-next: build failure after merge of the security tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Aug 2019 10:34:17 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     James Morris <jmorris@...ei.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Matthew Garrett <mjg59@...gle.com>,
        Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: linux-next: build failure after merge of the security tree

On Mon, Aug 12, 2019 at 02:58:23PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the security tree, today's linux-next build (arm
> multi_v7_defconfig) failed like below.
> 
> Caused by commit
> 
>   45d29f9e9b8b ("security: Support early LSMs")
> 
> I have added the following fix for today:
> 
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Mon, 12 Aug 2019 14:54:20 +1000
> Subject: [PATCH] early_security_init() needs a stub got !CONFIG_SECURITY
> 
> An arm multi_v7_defconfig fails like this:
> 
> init/main.c: In function 'start_kernel':
> init/main.c:596:2: error: implicit declaration of function 'early_security_init'; did you mean 'security_init'? [-Werror=implicit-function-declaration]
>   early_security_init();
>   ^~~~~~~~~~~~~~~~~~~
>   security_init
> 
> Fixes: 45d29f9e9b8b ("security: Support early LSMs")
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  include/linux/security.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/security.h b/include/linux/security.h
> index 807dc0d24982..23e1c3f17d48 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -473,6 +473,11 @@ static inline int security_init(void)
>  	return 0;
>  }
>  
> +static inline int early_security_init(void)
> +{
> +	return 0;
> +}
> +
>  static inline int security_binder_set_context_mgr(struct task_struct *mgr)
>  {
>  	return 0;
> -- 
> 2.20.1
> 
> -- 
> Cheers,
> Stephen Rothwell



-- 
Kees Cook