linux-kernel - Re: [PATCH v2 1/2] vfio-mdev/mtty: Simplify interrupt generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190813163930.GB22640@infradead.org>
Date:   Tue, 13 Aug 2019 09:39:30 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Parav Pandit <parav@...lanox.com>
Cc:     kvm@...r.kernel.org, kwankhede@...dia.com,
        linux-kernel@...r.kernel.org, alex.williamson@...hat.com,
        cohuck@...hat.com, cjia@...dia.com
Subject: Re: [PATCH v2 1/2] vfio-mdev/mtty: Simplify interrupt generation

On Thu, Aug 08, 2019 at 09:12:54AM -0500, Parav Pandit wrote:
> While generating interrupt, mdev_state is already available for which
> interrupt is generated.
> Instead of doing indirect way from state->device->uuid-> to searching
> state linearly in linked list on every interrupt generation,
> directly use the available state.
> 
> Hence, simplify the code to use mdev_state and remove unused helper
> function with that.
> 
> Reviewed-by: Cornelia Huck <cohuck@...hat.com>
> Signed-off-by: Parav Pandit <parav@...lanox.com>

Looks good, the old code is rather backwards and a bad example to
copy:

Reviewed-by: Christoph Hellwig <hch@....de>