[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f715d755-3f45-e90c-8913-7adec9f1dc9f@gmail.com>
Date: Tue, 13 Aug 2019 12:54:36 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Tao Ren <taoren@...com>, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
"David S . Miller" <davem@...emloft.net>,
Vladimir Oltean <olteanv@...il.com>,
Arun Parameswaran <arun.parameswaran@...adcom.com>,
Justin Chen <justinpopo6@...il.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH net-next] net: phy: modify assignment to OR for dev_flags
in phy_attach_direct
On 8/5/19 11:55 AM, Tao Ren wrote:
> Modify the assignment to OR when dealing with phydev->dev_flags in
> phy_attach_direct function, and this is to make sure dev_flags set in
> driver's probe callback won't be lost.
As Andrew pointed out already, this probably needs to be reworked, but
for now this looks reasonable:
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists