linux-kernel - [PATCH] mtd: hyperbus: fix dependency and build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b1b4ab1-681f-0ef9-7b5c-b6545f7464d2@infradead.org>
Date:   Tue, 13 Aug 2019 16:03:13 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-mtd@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org>
Cc:     Vignesh Raghavendra <vigneshr@...com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: [PATCH] mtd: hyperbus: fix dependency and build error

From: Randy Dunlap <rdunlap@...radead.org>

lib/devres.c, which implements devm_ioremap_resource(), is only built
when CONFIG_HAS_IOMEM is set/enabled, so MTD_HYPERBUS should depend
on HAS_IOMEM.  Fixes a build error and a Kconfig warning (as seen on
UML builds):

WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS
  Depends on [n]: MTD [=m] && HAS_IOMEM [=n]
  Selected by [m]:
  - MTD_HYPERBUS [=m] && MTD [=m]

ERROR: "devm_ioremap_resource" [drivers/mtd/hyperbus/hyperbus-core.ko] undefined!

Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Vignesh Raghavendra <vigneshr@...com>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: linux-mtd@...ts.infradead.org
---
 drivers/mtd/hyperbus/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- lnx-53-rc4.orig/drivers/mtd/hyperbus/Kconfig
+++ lnx-53-rc4/drivers/mtd/hyperbus/Kconfig
@@ -1,5 +1,6 @@
 menuconfig MTD_HYPERBUS
 	tristate "HyperBus support"
+	depends on HAS_IOMEM
 	select MTD_CFI
 	select MTD_MAP_BANK_WIDTH_2
 	select MTD_CFI_AMDSTD