linux-kernel - Re: [PATCH 4.9.y 4.14.y] IB/mlx5: Fix leaking stack memory to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190812160714.GA246269@google.com>
Date:   Tue, 13 Aug 2019 10:27:28 +0100
From:   Alessio Balsini <balsini@...roid.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...roid.com, Jason Gunthorpe <jgg@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        "hange-folder>?" <toggle-mailboxes@...gle.com>
Subject: Re: [PATCH 4.9.y 4.14.y] IB/mlx5: Fix leaking stack memory to
 userspace

Oops, you are totally right, I was still looking at the latest
mlx5_ib_create_qp_resp struct while backporting these patches :)

Sorry for that,
Alessio

On Mon, Aug 12, 2019 at 04:23:16PM +0200, Greg KH wrote:
> On Mon, Aug 12, 2019 at 11:55:03AM +0100, Alessio Balsini wrote:
> > From: Jason Gunthorpe <jgg@...lanox.com>
> > 
> > commit 0625b4ba1a5d4703c7fb01c497bd6c156908af00 upstream.
> > 
> > mlx5_ib_create_qp_resp was never initialized and only the first 4 bytes
> > were written.
> > 
> > Fixes: 41d902cb7c32 ("RDMA/mlx5: Fix definition of mlx5_ib_create_qp_resp")
> 
> This commit only showed up in the following kernel releases:
> 	4.17 4.18.7 4.19
> 
> so why is this "fix" commit needed in anything older than 4.17?
> 
> That's why I did not backport it to older kernels, as I do not think it
> is needed there.  Do you?
> 
> thanks,
> 
> greg k-h