linux-kernel - Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09642ea4-03b0-36be-1d52-6ef5e09f20d0@enpas.org>
Date:   Tue, 13 Aug 2019 11:50:02 +0200
From:   Max Staudt <max@...as.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Linux I2C <linux-i2c@...r.kernel.org>, linux-hwmon@...r.kernel.org,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Linux/m68k <linux-m68k@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Subject: Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

On 08/13/2019 09:08 AM, Geert Uytterhoeven wrote:
>> +       dev_info(&z->dev, "ICY I2C controller at %#x, IRQ not implemented\n",
>> +                z->resource.start);
> 
> z->resource.start has type phys_addr_t, so you should pas a reference, and
> use %pa to print it.
> Alternatively, you can print the full resource using %pR.
> See Documentation/core-api/printk-formats.rst

Ack, this snuck in from the early days. Thanks for pointing this out!


Max