linux-kernel - RE: [EXT] Re: [v6,2/2] dt-bindings: rtc: add bindings for FlexTimer Module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB7PR04MB44902C6FDEC187F11B6E98718FD20@DB7PR04MB4490.eurprd04.prod.outlook.com>
Date:   Tue, 13 Aug 2019 02:59:12 +0000
From:   Biwen Li <biwen.li@....com>
To:     Rob Herring <robh@...nel.org>
CC:     "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        Leo Li <leoyang.li@....com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Xiaobo Xie <xiaobo.xie@....com>,
        Jiafei Pan <jiafei.pan@....com>, Ran Wang <ran.wang_1@....com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [EXT] Re: [v6,2/2] dt-bindings: rtc: add bindings for FlexTimer
 Module

> 
> On Fri, Jul 19, 2019 at 11:54:00AM +0800, Biwen Li wrote:
> > The patch adds bindings for FlexTimer Module
> >
> > Signed-off-by: Biwen Li <biwen.li@....com>
> > ---
> > Change in v6:
> >     - correct subject
> >     - delete note
> >     - remove reg property about IP Powerdown exception register
> >
> > Change in v5:
> >     - None
> >
> > Change in v4:
> >     - add note about dts and kernel options
> >     - add aliases in example
> >
> > Change in v3:
> >       - remove reg-names property
> >       - correct cells number
> >
> > Change in v2:
> >       - replace ls1043a with ls1088a as example
> >       - add rcpm node and fsl,rcpm-wakeup property
> >
> >  .../bindings/rtc/rtc-fsl-ftm-alarm.txt        | 41 +++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> > b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> > new file mode 100644
> > index 000000000000..9291b022ffc7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> > @@ -0,0 +1,41 @@
> > +Freescale FlexTimer Module (FTM) Alarm
> > +
> > +Required properties:
> > +- compatible : Should be "fsl,<chip>-ftm-alarm", the
> > +            supported chips include
> > +            "fsl,ls1012a-ftm-alarm"
> > +            "fsl,ls1021a-ftm-alarm"
> > +            "fsl,ls1028a-ftm-alarm"
> > +            "fsl,ls1043a-ftm-alarm"
> > +            "fsl,ls1046a-ftm-alarm"
> > +            "fsl,ls1088a-ftm-alarm"
> > +            "fsl,ls208xa-ftm-alarm"
> > +- reg : Specifies base physical address and size of the register sets
> > +for the
> > +  FlexTimer Module.
> > +- interrupts : Should be the FlexTimer Module interrupt.
> > +- fsl,rcpm-wakeup property and rcpm node : Please refer
> > +     Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > +
> > +Optional properties:
> > +- big-endian: If the host controller is big-endian mode, specify this property.
> > +  The default endian mode is little-endian.
> > +
> > +Example:
> > +aliases {
> > +     ...
> > +     rtc1 = ftm_alarm0; // Use FlexTimer Module as /dev/rtc1
> > +     ...
> > +};
> 
> As I said before, drop this. It's not going to work when this is converted to
> schema and the example is compiled. Feel free to convert this to schema and
> see...
Ok, got it. I will drop this in v7.
> 
> > +
> > +rcpm: rcpm@...4040 {
> > +     compatible = "fsl,ls1088a-rcpm", "fsl,qoriq-rcpm-2.1+";
> > +     reg = <0x0 0x1e34040 0x0 0x18>;
> > +     #fsl,rcpm-wakeup-cells = <6>;
> > +};
> > +
> > +ftm_alarm0: timer@...0000 {
> 
> If this is an RTC, then rtc@...
This is not an RTC.
> 
> > +     compatible = "fsl,ls1088a-ftm-alarm";
> > +     reg = <0x0 0x2800000 0x0 0x10000>;
> > +     fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000 0x0>;
> > +     interrupts = <0 44 4>;
> > +};
> > --
> > 2.17.1
> >