linux-kernel - Re: Regression in Linux next with show wakeup sources stats in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d542133.1c69fb81.f5f57.0098@mx.google.com>
Date:   Wed, 14 Aug 2019 07:56:50 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Tony Lindgren <tony@...mide.com>
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kalesh Singh <kaleshsingh@...gle.com>,
        Tri Vo <trong@...roid.com>, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-pm@...r.kernel.org, Sebastian Reichel <sre@...nel.org>
Subject: Re: Regression in Linux next with show wakeup sources stats in sysfs

Quoting Tony Lindgren (2019-08-14 00:32:34)
> * Stephen Boyd <swboyd@...omium.org> [190814 07:09]:
> > Quoting Tony Lindgren (2019-08-13 23:38:03)
> > > Hi all,
> > > 
> > > Looks like commit 986845e747af ("PM / wakeup: Show wakeup sources stats
> > > in sysfs") has caused a regression in Linux next where I can now get
> > > some errors like this during the boot:
> > > 
> > > kobject_add_internal failed for wakeup10 (error: -2 parent: usb)
> > > 
> > > Any ideas why this might be happening? Maybe some deferred probe
> > > related issue?
> > > 
> > 
> > Yeah! Take a look at this thread[1] and please test out patches I'm
> > throwing out there like a total cowboy(d).
> > 
> > [1] https://lkml.kernel.org/r/1565731976.8572.16.camel@lca.pw
> 
> Oh OK thanks, looks like I'm a bit behind then. My test case turned
> out to be caused by device_init_wakeup() called before device_add() for
> power_supply in case that helps. In that case create_dir() will fail
> for kobject_add_internal(). Doing something like below fixes the
> issue, but seems like we probably have other similar issues as well.
> Adding Sebastian to Cc in case this might be a real problem despite
> the other issues.
> 

Ah yeah. I sent a patch for power supply earlier[2], but now I'm
thinking that it would be better to take the approach in the thread I
mentioned where we just don't add sysfs stuff until when device_add() is
called.

[2] https://lkml.kernel.org/r/20190801213330.81079-1-swboyd@chromium.org