linux-kernel - Re: [PATCH] scsi: mvumi: fix 32 bit shift of a u32 value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Aug 2019 23:07:53 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Colin King <colin.king@...onical.com>
Cc:     kbuild-all@...org, Jianyun Li <jyli@...vell.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: mvumi: fix 32 bit shift of a u32 value

Hi Colin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc4 next-20190814]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Colin-King/scsi-mvumi-fix-32-bit-shift-of-a-u32-value/20190814-214025
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/mvumi.c: In function 'mvumi_delete_internal_cmd':
>> drivers/scsi/mvumi.c:299:38: warning: left shift count >= width of type [-Wshift-count-overflow]
           (dma_addr_t) m_sg->baseaddr_h << 32;
                                         ^~

vim +299 drivers/scsi/mvumi.c

   285	
   286	static void mvumi_delete_internal_cmd(struct mvumi_hba *mhba,
   287							struct mvumi_cmd *cmd)
   288	{
   289		struct mvumi_sgl *m_sg;
   290		unsigned int size;
   291		dma_addr_t phy_addr;
   292	
   293		if (cmd && cmd->frame) {
   294			if (cmd->frame->sg_counts) {
   295				m_sg = (struct mvumi_sgl *) &cmd->frame->payload[0];
   296				sgd_getsz(mhba, m_sg, size);
   297	
   298				phy_addr = (dma_addr_t) m_sg->baseaddr_l |
 > 299					   (dma_addr_t) m_sg->baseaddr_h << 32;
   300	
   301				dma_free_coherent(&mhba->pdev->dev, size, cmd->data_buf,
   302									phy_addr);
   303			}
   304			dma_free_coherent(&mhba->pdev->dev, mhba->ib_max_size,
   305					cmd->frame, cmd->frame_phys);
   306			kfree(cmd);
   307		}
   308	}
   309	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (61472 bytes)