[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f13feaee-0bad-a774-5527-296b6f74c91b@gmail.com>
Date: Wed, 14 Aug 2019 10:57:19 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Alexandru Ardelean <alexandru.ardelean@...log.com>,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: davem@...emloft.net, robh+dt@...nel.org, mark.rutland@....com,
hkallweit1@...il.com, andrew@...n.ch
Subject: Re: [PATCH v4 11/14] net: phy: adin: implement Energy Detect
Powerdown mode
On 8/12/2019 4:23 AM, Alexandru Ardelean wrote:
> The ADIN PHYs support Energy Detect Powerdown mode, which puts the PHY into
> a low power mode when there is no signal on the wire (typically cable
> unplugged).
> This behavior is enabled by default, but can be disabled via device
> property.
We could consider adding a PHY tunable, having this as a Device Tree
property amounts to putting a policy inside DT, which is frowned upon.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
Other than that, the code looks fine:
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists