linux-kernel - Re: [PATCH 1/4] drivers: qcom: rpmh: fix macro to accept NULL argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d544c0f.1c69fb81.a78d3.1381@mx.google.com>
Date:   Wed, 14 Aug 2019 10:59:42 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Maulik Shah <mkshah@...eaurora.org>, agross@...nel.org,
        david.brown@...aro.org, linux-arm-msm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        bjorn.andersson@...aro.org, evgreen@...omium.org,
        dianders@...omium.org, rnayak@...eaurora.org, ilina@...eaurora.org,
        lsrao@...eaurora.org, ulf.hansson@...aro.org,
        Maulik Shah <mkshah@...eaurora.org>
Subject: Re: [PATCH 1/4] drivers: qcom: rpmh: fix macro to accept NULL argument

Quoting Maulik Shah (2019-08-13 01:24:39)
> Device argument matches with dev variable declared in RPMH message.
> Compiler reports error when the argument is NULL since the argument
> matches the name of the property. Rename dev argument to device to
> fix this.
> 
> Signed-off-by: Maulik Shah <mkshah@...eaurora.org>
> ---

Maybe this should have a Fixes tag? And the subject could be something
like "avoid shadowing local variables in macro"?

Reviewed-by: Stephen Boyd <swboyd@...omium.org>