lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Aug 2019 13:31:32 -0600 From: Keith Busch <kbusch@...nel.org> To: Mario Limonciello <mario.limonciello@...l.com> Cc: Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>, LKML <linux-kernel@...r.kernel.org>, Ryan Hong <Ryan.Hong@...l.com>, Crag Wang <Crag.Wang@...l.com>, "sjg@...gle.com" <sjg@...gle.com>, Charles Hyde <charles.hyde@...lteam.com>, Jared Dominguez <jared.dominguez@...l.com> Subject: Re: [PATCH] nvme: Add quirk for LiteON CL1 devices running FW 22301111 On Wed, Aug 14, 2019 at 09:05:49AM -0700, Mario Limonciello wrote: > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index 8f3fbe5..47c7754 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -2251,6 +2251,29 @@ static const struct nvme_core_quirk_entry core_quirks[] = { > .vid = 0x1179, > .mn = "THNSF5256GPUK TOSHIBA", > .quirks = NVME_QUIRK_NO_APST, > + }, > + /* > + * This LiteON CL1 firmware version has a race condition associated with > + * actions related to suspend to idle. LiteON has resolved the problem > + * in future firmware. > + */ > + { > + .vid = 0x14a4, > + .mn = "CL1-3D128-Q11 NVMe LITEON 128GB", > + .fr = "22301111", > + .quirks = NVME_QUIRK_SIMPLE_SUSPEND, > + }, > + { > + .vid = 0x14a4, > + .mn = "CL1-3D256-Q11 NVMe LITEON 256GB", > + .fr = "22301111", > + .quirks = NVME_QUIRK_SIMPLE_SUSPEND, > + }, > + { > + .vid = 0x14a4, > + .mn = "CL1-3D512-Q11 NVMe LITEON 512GB", > + .fr = "22301111", > + .quirks = NVME_QUIRK_SIMPLE_SUSPEND, > } > }; Are there models from this vendor with this same 'fr' that don't need this quirk? If not, you can leave .mn blank and just use a single entry.
Powered by blists - more mailing lists