[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190814194714.GB9756@kunai>
Date: Wed, 14 Aug 2019 21:47:14 +0200
From: Wolfram Sang <wsa@...-dreams.de>
To: Max Staudt <max@...as.org>
Cc: linux-i2c@...r.kernel.org, linux-hwmon@...r.kernel.org,
Wolfram Sang <wsa+renesas@...g-engineering.com>,
Jean Delvare <jdelvare@...e.com>,
Guenter Roeck <linux@...ck-us.net>, linux-m68k@...r.kernel.org,
linux-kernel@...r.kernel.org, glaubitz@...sik.fu-berlin.de
Subject: Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga
Hi,
Thanks for the patch. It looks mostly good.
> +static int clock = 0x1c;
> +module_param(clock, int, 0444);
'clock' determines the bus speed?
> + i2c->adapter.class = I2C_CLASS_DEPRECATED;
This is only needed for drivers which used to have a class and decided
to drop it. You can leave it empty.
> + algo_data->data = (void *)i2c;
You don't need the cast, do you?
> +MODULE_LICENSE("GPL");
Your SPDX header says GPL 2.0 only.
Kind regards,
Wolfram
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists