[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1391be01-932c-68ca-0160-e08ed2a0243d@nvidia.com>
Date: Wed, 14 Aug 2019 13:14:24 -0700
From: Ralph Campbell <rcampbell@...dia.com>
To: Jason Gunthorpe <jgg@...pe.ca>, <linux-mm@...ck.org>
CC: Andrea Arcangeli <aarcange@...hat.com>,
Christoph Hellwig <hch@....de>,
John Hubbard <jhubbard@...dia.com>,
Jérôme Glisse <jglisse@...hat.com>,
"Kuehling, Felix" <Felix.Kuehling@....com>,
"Alex Deucher" <alexander.deucher@....com>,
Christian König <christian.koenig@....com>,
"David (ChunMing) Zhou" <David1.Zhou@....com>,
Dimitri Sivanich <sivanich@....com>,
<dri-devel@...ts.freedesktop.org>, <amd-gfx@...ts.freedesktop.org>,
<linux-kernel@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
<iommu@...ts.linux-foundation.org>,
<intel-gfx@...ts.freedesktop.org>,
Gavin Shan <shangw@...ux.vnet.ibm.com>,
Andrea Righi <andrea@...terlinux.com>,
Jason Gunthorpe <jgg@...lanox.com>,
Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH v3 hmm 01/11] mm/mmu_notifiers: hoist
do_mmu_notifier_register down_write to the caller
On 8/6/19 4:15 PM, Jason Gunthorpe wrote:
> From: Jason Gunthorpe <jgg@...lanox.com>
>
> This simplifies the code to not have so many one line functions and extra
> logic. __mmu_notifier_register() simply becomes the entry point to
> register the notifier, and the other one calls it under lock.
>
> Also add a lockdep_assert to check that the callers are holding the lock
> as expected.
>
> Suggested-by: Christoph Hellwig <hch@...radead.org>
> Signed-off-by: Jason Gunthorpe <jgg@...lanox.com>
Nice clean up.
Reviewed-by: Ralph Campbell <rcampbell@...dia.com>
Powered by blists - more mailing lists