linux-kernel - Re: [PATCH 2/2] riscv: Make __fstate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABvJ_xiwDrOE1yCsBWe6qF=WU1pgi=kE8+GHfar-q+Tov0vYpQ@mail.gmail.com>
Date:   Wed, 14 Aug 2019 09:55:49 +0800
From:   Vincent Chen <vincent.chen@...ive.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        linux-riscv <linux-riscv@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] riscv: Make __fstate_clean() can work correctly.

On Mon, Aug 12, 2019 at 10:59 PM Christoph Hellwig <hch@...radead.org> wrote:
>
> Maybe s/can //g in the subject?
>
> > +     regs->sstatus = (regs->sstatus & ~(SR_FS)) | SR_FS_CLEAN;
>
> No need for the inner braces here either.
OK, I will remove them.

>
> Otherwise:
>
> Reviewed-by: Christoph Hellwig <hch@....de>

Thanks for your comments

Regards,
Vincent Chen