linux-kernel - Re: [Cocci] [PATCH v2 08/10] scripts: Coccinelle script for namespace dependencies.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190814063611.GA22387@himanshu-Vostro-3559>
Date:   Wed, 14 Aug 2019 12:06:11 +0530
From:   Himanshu Jha <himanshujha199640@...il.com>
To:     Matthias Maennich <maennich@...gle.com>
Cc:     linux-kernel@...r.kernel.org, maco@...roid.com,
        kstewart@...uxfoundation.org, linux-m68k@...r.kernel.org,
        oneukum@...e.com,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        usb-storage@...ts.one-eyed-alien.net, hpa@...or.com,
        joel@...lfernandes.org, sam@...nborg.org, cocci@...teme.lip6.fr,
        linux-arch@...r.kernel.org, linux-scsi@...r.kernel.org,
        x86@...nel.org, lucas.de.marchi@...il.com, mingo@...hat.com,
        geert@...ux-m68k.org, stern@...land.harvard.edu,
        kernel-team@...roid.com, sspatil@...gle.com, arnd@...db.de,
        linux-kbuild@...r.kernel.org,
        Nicolas Palix <nicolas.palix@...g.fr>, jeyu@...nel.org,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        tglx@...utronix.de, michal.lkml@...kovi.net,
        gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        sboyd@...eaurora.org, Nicolas Ferre <nicolas.ferre@...rochip.com>,
        maco@...gle.com, pombredanne@...b.com,
        "David S. Miller" <davem@...emloft.net>,
        linux-modules@...r.kernel.org
Subject: Re: [Cocci] [PATCH v2 08/10] scripts: Coccinelle script for
 namespace dependencies.

On Tue, Aug 13, 2019 at 01:17:05PM +0100, Matthias Maennich wrote:
> A script that uses the '<module>.ns_deps' file generated by modpost to
> automatically add the required symbol namespace dependencies to each
> module.
> 
> Usage:
> 1) Move some symbols to a namespace with EXPORT_SYMBOL_NS() or define
>    DEFAULT_SYMBOL_NAMESPACE
> 2) Run 'make' (or 'make modules') and get warnings about modules not
>    importing that namespace.
> 3) Run 'make nsdeps' to automatically add required import statements
>    to said modules.
> 
> This makes it easer for subsystem maintainers to introduce and maintain
> symbol namespaces into their codebase.
> 
> Co-developed-by: Martijn Coenen <maco@...roid.com>
> Signed-off-by: Martijn Coenen <maco@...roid.com>
> Signed-off-by: Matthias Maennich <maennich@...gle.com>
> ---

[]

>  MAINTAINERS                                 |  5 ++
>  Makefile                                    | 12 +++++
>  scripts/Makefile.modpost                    |  4 +-
>  scripts/coccinelle/misc/add_namespace.cocci | 23 +++++++++
>  scripts/nsdeps                              | 54 +++++++++++++++++++++
>  5 files changed, 97 insertions(+), 1 deletion(-)
>  create mode 100644 scripts/coccinelle/misc/add_namespace.cocci
>  create mode 100644 scripts/nsdeps

[]

> +if [ "$SPATCH_VERSION_NUM" -lt "$SPATCH_REQ_VERSION_NUM" ] ; then
> +    echo 'spatch needs to be version 1.06 or higher'

Nitpick: 1.0.6

> +    exit 1
> +fi


-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology