linux-kernel - Re: [PATCHv2 0/4] blk_execute_rq{

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Aug 2019 23:05:40 -0300
From:   Marcos Paulo de Souza <marcos.souza.org@...il.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     linux-kernel@...r.kernel.org, hch@....de,
        linux-block@...r.kernel.org
Subject: Re: [PATCHv2 0/4] blk_execute_rq{_nowait} cleanup part1

On Sun, Aug 11, 2019 at 07:47:17AM -0600, Jens Axboe wrote:
> On 8/9/19 3:54 AM, Marcos Paulo de Souza wrote:
> > After checking the request_queue argument of funtion blk_execute_rq_nowait, I
> > now added three more patches, one to remove the same argument from
> > blk_execute_rq and other two to change the at_head argument from
> > blk_exeute_rq_{nowait} from int to bool.
> > 
> > Original patch can be checked here[1].
> > 
> > After this patch gets merged, my plan is to analyse the usage the gendisk
> > argument, is being set as NULL but the majority of callers.
> > 
> > [1]: https://lkml.org/lkml/2019/8/6/31
> 
> Don't ever send something out that hasn't even been compiled. I already
> detest doing kernel-wide cleanup changes like this, but when I do, I
> need absolute confidence in it actually being tested. The fact that it
> hasn't even been compiled is a big black mark on the submitter.

My bad. I compiled the code locally and tested in VM, but later on I removed
the semicolon by mistake while reviewing the changes once more and the code
was commited without the semicolon. I'm improving my setup (scripts
and whatnot) to avoid this happening again in the future.

> 
> -- 
> Jens Axboe
>