linux-kernel - Re: [PATCH] PCI: dwc: Add map irq callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe722a89-37e7-9ef6-042b-a9584f234740@linux.intel.com>
Date:   Wed, 14 Aug 2019 16:31:14 +0800
From:   Dilip Kota <eswara.kota@...ux.intel.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     jingoohan1@...il.com, gustavo.pimentel@...opsys.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        andriy.shevchenko@...el.com
Subject: Re: [PATCH] PCI: dwc: Add map irq callback

Hi Christoph Hellwig,

On 8/14/2019 3:36 PM, Christoph Hellwig wrote:
> On Wed, Aug 14, 2019 at 02:56:49PM +0800, Dilip Kota wrote:
>> Certain platforms like Intel need to configure
>> registers to enable the interrupts.
>> Map Irq callback helps to perform platform specific
>> configurations while assigning or enabling the interrupts.
> This seems to miss the hunk that actually assigns the map_irq
> callback.
pp->map_irq() must assign the callback along with the platform specific 
configuration.
In Intel PCIe driver pp->map_irq() does the same. (Driver is not yet 
present in mainline, i will submit for review once this change is approved).
>> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
>> index f93252d0da5b..5880d2b72ef8 100644
>> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
>> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
>> @@ -470,7 +470,7 @@ int dw_pcie_host_init(struct pcie_port *pp)
>>   	bridge->sysdata = pp;
>>   	bridge->busnr = pp->root_bus_nr;
>>   	bridge->ops = &dw_pcie_ops;
>> -	bridge->map_irq = of_irq_parse_and_map_pci;
>> +	bridge->map_irq = pp->map_irq ? pp->map_irq : of_irq_parse_and_map_pci;
> Pleae just use a classic if / else to make the code a little easier
> to read.

Noted, will update it.

--Dilip