linux-kernel - Re: [PATCH v5 03/15] ASoC: sun4i-i2s: Correct divider calculations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190814093117.GE4640@sirena.co.uk>
Date:   Wed, 14 Aug 2019 10:31:17 +0100
From:   Mark Brown <broonie@...nel.org>
To:     codekipper@...il.com
Cc:     maxime.ripard@...e-electrons.com, wens@...e.org,
        linux-sunxi@...glegroups.com, linux-arm-kernel@...ts.infradead.org,
        lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        alsa-devel@...a-project.org, be17068@...rbole.bo.it
Subject: Re: [PATCH v5 03/15] ASoC: sun4i-i2s: Correct divider calculations

On Wed, Aug 14, 2019 at 08:08:42AM +0200, codekipper@...il.com wrote:

> +	if (i2s->variant->has_fmt_set_lrck_period)
> +		bclk_div = sun4i_i2s_get_bclk_div(i2s, clk_rate / rate,
> +						  word_size,
> +						  sun8i_i2s_clk_div,
> +						  ARRAY_SIZE(sun8i_i2s_clk_div));
> +	else
> +		bclk_div = sun4i_i2s_get_bclk_div(i2s, oversample_rate,
> +						  word_size,
> +						  sun4i_i2s_bclk_div,
> +						  ARRAY_SIZE(sun4i_i2s_bclk_div));

Are we sure there'll never be any new variants which would make a switch
statement for the variant work better?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)