linux-kernel - Re: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Aug 2019 12:09:30 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Biwen Li <biwen.li@....com>
Cc:     a.zummo@...ertech.it, leoyang.li@....com,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

Hi,

On 14/08/2019 17:32:49+0800, Biwen Li wrote:
> Issue:
>     # hwclock -w
>     hwclock: RTC_SET_TIME: Invalid argument
> 
> The patch fixes error when run command hwclock -w
> with rtc pcf85363/pcf85263
> 

Could you describe a bit more the issue and what causes it?

IIRC I wrote that code and it works on my pcf85363.

> Signed-off-by: Biwen Li <biwen.li@....com>
> ---
>  drivers/rtc/rtc-pcf85363.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c
> index a075e77617dc..3450d615974d 100644
> --- a/drivers/rtc/rtc-pcf85363.c
> +++ b/drivers/rtc/rtc-pcf85363.c
> @@ -166,7 +166,12 @@ static int pcf85363_rtc_set_time(struct device *dev, struct rtc_time *tm)
>  	buf[DT_YEARS] = bin2bcd(tm->tm_year % 100);
>  
>  	ret = regmap_bulk_write(pcf85363->regmap, CTRL_STOP_EN,
> -				tmp, sizeof(tmp));
> +				tmp, 2);
> +	if (ret)
> +		return ret;
> +
> +	ret = regmap_bulk_write(pcf85363->regmap, DT_100THS,
> +				buf, sizeof(tmp) - 2);
>  	if (ret)
>  		return ret;
>  
> -- 
> 2.17.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com