linux-kernel - Re: [PATCH] selftests: livepatch: add missing fragments to config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e01a1182-d9cf-b2c2-78a9-35f60861e4a9@redhat.com>
Date:   Wed, 14 Aug 2019 09:20:49 -0400
From:   Joe Lawrence <joe.lawrence@...hat.com>
To:     Anders Roxell <anders.roxell@...aro.org>, shuah@...nel.org,
        pmladek@...e.com, mbenes@...e.cz, jikos@...nel.org,
        jpoimboe@...hat.com
Cc:     live-patching@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: livepatch: add missing fragments to config

On 8/14/19 7:16 AM, Anders Roxell wrote:
> When generating config with 'make defconfig kselftest-merge' fragment
> CONFIG_TEST_LIVEPATCH=m isn't set.
> 
> Rework to enable CONFIG_LIVEPATCH and CONFIG_DYNAMIC_DEBUG as well.
> 
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> ---
>   tools/testing/selftests/livepatch/config | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/livepatch/config b/tools/testing/selftests/livepatch/config
> index 0dd7700464a8..ad23100cb27c 100644
> --- a/tools/testing/selftests/livepatch/config
> +++ b/tools/testing/selftests/livepatch/config
> @@ -1 +1,3 @@
> +CONFIG_LIVEPATCH=y
> +CONFIG_DYNAMIC_DEBUG=y
>   CONFIG_TEST_LIVEPATCH=m
> 

Cool, I didn't know about that make target when doing commit 
bae054372aba ("selftests/livepatch: add DYNAMIC_DEBUG config dependency")

How does kselftest-merge verify dependencies?

CONFIG_LIVEPATCH has its own list of configuration dependencies (see 
kernel/livepatch/Kconfig) but we don't list all of those in this config 
file.  Just curious.

Thanks,

-- Joe