linux-kernel - Re: [GIT PULL] xfs: fixes for 5.3-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiHuHLK49LKQhtERXaq0OYUnug4DJZFLPq9RHEG2Cm+bQ@mail.gmail.com>
Date:   Thu, 15 Aug 2019 12:38:33 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     "Darrick J. Wong" <djwong@...nel.org>
Cc:     linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        linux-xfs <linux-xfs@...r.kernel.org>,
        Dave Chinner <david@...morbit.com>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        Eric Sandeen <sandeen@...deen.net>,
        Christoph Hellwig <hch@....de>
Subject: Re: [GIT PULL] xfs: fixes for 5.3-rc5

Pulled. Just a quick note:

On Thu, Aug 15, 2019 at 10:13 AM Darrick J. Wong <djwong@...nel.org> wrote:
>
> - Convert more directory corruption debugging asserts to actual
>   EFSCORRUPTED returns instead of blowing up later on.

The proper error code looks like an obvious improvement, but I do
wonder if there should be some (ratelimited) system logging too?

I've seen a lot of programs that don't report errors very clearly and
might just silently stop running and as a sysadmin I'd think I'd
rather have something in the system logs than users saying "my app
crashes at startup"/

Maybe the logging ends up being there already - just done later. It
wasn't obvious from the patch, and I didn't check the whole callchain
(only direct callers).

                  Linus