linux-kernel - Re: [PATCH 2/3] soc: fsl: dpio: remove explicit device_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Aug 2019 18:17:27 -0500
From:   Li Yang <leoyang.li@....com>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     Laurentiu Tudor <laurentiu.tudor@....com>,
        Roy Pledge <Roy.Pledge@....com>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] soc: fsl: dpio: remove explicit device_link_remove

On Wed, Jul 3, 2019 at 9:58 AM Ioana Ciornei <ioana.ciornei@....com> wrote:
>
> Starting with commit 72175d4ea4c4 ("driver core: Make driver core
> own stateful device links") stateful device links are owned by the
> driver core and should not be explicitly removed on device unbind.
> Delete all device_link_remove appearances from the dpio driver.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

Applied for next.  Thanks.

> ---
>  drivers/soc/fsl/dpio/dpio-service.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/fsl/dpio/dpio-service.c b/drivers/soc/fsl/dpio/dpio-service.c
> index b9539ef2c3cd..518a8e081b49 100644
> --- a/drivers/soc/fsl/dpio/dpio-service.c
> +++ b/drivers/soc/fsl/dpio/dpio-service.c
> @@ -305,8 +305,6 @@ void dpaa2_io_service_deregister(struct dpaa2_io *service,
>         list_del(&ctx->node);
>         spin_unlock_irqrestore(&d->lock_notifications, irqflags);
>
> -       if (dev)
> -               device_link_remove(dev, d->dev);
>  }
>  EXPORT_SYMBOL_GPL(dpaa2_io_service_deregister);
>
> --
> 1.9.1
>