lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGgjyvG-g7tHjQGAvd6_19+XhzaZTRVdj5CBRUxbvTHx2y5i=A@mail.gmail.com>
Date:   Thu, 15 Aug 2019 07:37:21 +0000
From:   Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
To:     Philippe Schenker <philippe.schenker@...adex.com>
CC:     "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [RESEND PATCH] ARM: dts: Add stmpe-adc DT node to Toradex T30
 modules

On Wed, Aug 14, 2019 at 1:54 PM Philippe Schenker
<philippe.schenker@...adex.com> wrote:
>
> Add the stmpe-adc DT node as found on Toradex T30 modules
>
> Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@...adex.com>

>
> ---
>
>  arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 22 ++++++++++++++--------
>  arch/arm/boot/dts/tegra30-apalis.dtsi      | 22 ++++++++++++++--------
>  arch/arm/boot/dts/tegra30-colibri.dtsi     | 22 ++++++++++++++--------
>  3 files changed, 42 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> index 02f8126481a2..8b7a827d604d 100644
> --- a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> @@ -994,11 +994,17 @@
>                         id = <0>;
>                         blocks = <0x5>;
>                         irq-trigger = <0x1>;
> +                       /* 3.25 MHz ADC clock speed */
> +                       st,adc-freq = <1>;
> +                       /* 12-bit ADC */
> +                       st,mod-12b = <1>;
> +                       /* internal ADC reference */
> +                       st,ref-sel = <0>;
> +                       /* ADC converstion time: 80 clocks */
> +                       st,sample-time = <4>;
>
>                         stmpe_touchscreen {
>                                 compatible = "st,stmpe-ts";
> -                               /* 3.25 MHz ADC clock speed */
> -                               st,adc-freq = <1>;
>                                 /* 8 sample average control */
>                                 st,ave-ctrl = <3>;
>                                 /* 7 length fractional part in z */
> @@ -1008,17 +1014,17 @@
>                                  * current limit value
>                                  */
>                                 st,i-drive = <1>;
> -                               /* 12-bit ADC */
> -                               st,mod-12b = <1>;
> -                               /* internal ADC reference */
> -                               st,ref-sel = <0>;
> -                               /* ADC converstion time: 80 clocks */
> -                               st,sample-time = <4>;
>                                 /* 1 ms panel driver settling time */
>                                 st,settling = <3>;
>                                 /* 5 ms touch detect interrupt delay */
>                                 st,touch-det-delay = <5>;
>                         };
> +
> +                       stmpe_adc {
> +                               compatible = "st,stmpe-adc";
> +                               /* forbid to use ADC channels 3-0 (touch) */
> +                               st,norequest-mask = <0x0F>;
> +                       };
>                 };
>
>                 /*
> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
> index 7f112f192fe9..c18f6f61d764 100644
> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
> @@ -976,11 +976,17 @@
>                         id = <0>;
>                         blocks = <0x5>;
>                         irq-trigger = <0x1>;
> +                       /* 3.25 MHz ADC clock speed */
> +                       st,adc-freq = <1>;
> +                       /* 12-bit ADC */
> +                       st,mod-12b = <1>;
> +                       /* internal ADC reference */
> +                       st,ref-sel = <0>;
> +                       /* ADC converstion time: 80 clocks */
> +                       st,sample-time = <4>;
>
>                         stmpe_touchscreen {
>                                 compatible = "st,stmpe-ts";
> -                               /* 3.25 MHz ADC clock speed */
> -                               st,adc-freq = <1>;
>                                 /* 8 sample average control */
>                                 st,ave-ctrl = <3>;
>                                 /* 7 length fractional part in z */
> @@ -990,17 +996,17 @@
>                                  * current limit value
>                                  */
>                                 st,i-drive = <1>;
> -                               /* 12-bit ADC */
> -                               st,mod-12b = <1>;
> -                               /* internal ADC reference */
> -                               st,ref-sel = <0>;
> -                               /* ADC converstion time: 80 clocks */
> -                               st,sample-time = <4>;
>                                 /* 1 ms panel driver settling time */
>                                 st,settling = <3>;
>                                 /* 5 ms touch detect interrupt delay */
>                                 st,touch-det-delay = <5>;
>                         };
> +
> +                       stmpe_adc {
> +                               compatible = "st,stmpe-adc";
> +                               /* forbid to use ADC channels 3-0 (touch) */
> +                               st,norequest-mask = <0x0F>;
> +                       };
>                 };
>
>                 /*
> diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
> index 35af03ca9e90..1f9198bb24ff 100644
> --- a/arch/arm/boot/dts/tegra30-colibri.dtsi
> +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
> @@ -845,11 +845,18 @@
>                         id = <0>;
>                         blocks = <0x5>;
>                         irq-trigger = <0x1>;
> +                       /* 3.25 MHz ADC clock speed */
> +                       st,adc-freq = <1>;
> +                       /* 12-bit ADC */
> +                       st,mod-12b = <1>;
> +                       /* internal ADC reference */
> +                       st,ref-sel = <0>;
> +                       /* ADC converstion time: 80 clocks */
> +                       st,sample-time = <4>;
> +                       /* forbid to use ADC channels 3-0 (touch) */
>
>                         stmpe_touchscreen {
>                                 compatible = "st,stmpe-ts";
> -                               /* 3.25 MHz ADC clock speed */
> -                               st,adc-freq = <1>;
>                                 /* 8 sample average control */
>                                 st,ave-ctrl = <3>;
>                                 /* 7 length fractional part in z */
> @@ -859,17 +866,16 @@
>                                  * current limit value
>                                  */
>                                 st,i-drive = <1>;
> -                               /* 12-bit ADC */
> -                               st,mod-12b = <1>;
> -                               /* internal ADC reference */
> -                               st,ref-sel = <0>;
> -                               /* ADC converstion time: 80 clocks */
> -                               st,sample-time = <4>;
>                                 /* 1 ms panel driver settling time */
>                                 st,settling = <3>;
>                                 /* 5 ms touch detect interrupt delay */
>                                 st,touch-det-delay = <5>;
>                         };
> +
> +                       stmpe_adc {
> +                               compatible = "st,stmpe-adc";
> +                               st,norequest-mask = <0x0F>;
> +                       };
>                 };
>
>                 /*
> --
> 2.22.0
>


-- 
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ