linux-kernel - Re: [PATCH v4 4/8] printk: Replace strncmp with str_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190815075033.GA26479@tigerII.localdomain>
Date:   Thu, 15 Aug 2019 16:50:33 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Chuhong Yuan <hslester96@...il.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/8] printk: Replace strncmp with str_has_prefix

On (08/14/19 12:49), Petr Mladek wrote:
> On Fri 2019-08-09 15:10:34, Chuhong Yuan wrote:
> > strncmp(str, const, len) is error-prone because len
> > is easy to have typo.
> > The example is the hard-coded len has counting error
> > or sizeof(const) forgets - 1.
> > So we prefer using newly introduced str_has_prefix()
> > to substitute such strncmp to make code better.
> > 
> > Signed-off-by: Chuhong Yuan <hslester96@...il.com>
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>

Reviewed-by:  Sergey Senozhatsky <sergey.senozhatsky@...il.com>

	-ss