linux-kernel - Re: [PATCH] net: usbnet: fix a memory leak bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1565865720.5780.3.camel@suse.com>
Date:   Thu, 15 Aug 2019 12:42:00 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Wenwen Wang <wenwen@...uga.edu>
Cc:     "David S. Miller" <davem@...emloft.net>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:USB NETWORKING DRIVERS" <linux-usb@...r.kernel.org>,
        "open list:USB USBNET DRIVER FRAMEWORK" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: usbnet: fix a memory leak bug

Am Mittwoch, den 14.08.2019, 12:41 -0500 schrieb Wenwen Wang:
> In usbnet_start_xmit(), 'urb->sg' is allocated through kmalloc_array() by
> invoking build_dma_sg(). Later on, if 'CONFIG_PM' is defined and the if
> branch is taken, the execution will go to the label 'deferred'. However,
> 'urb->sg' is not deallocated on this execution path, leading to a memory
> leak bug.

Just to make this clear:

> Signed-off-by: Wenwen Wang <wenwen@...uga.edu>
NACK

For the reason Jack explained. Deferral is not a failure.

	Regards
		Oliver