linux-kernel - Re: [PATCH] Fix fTPM on AMD Zen+ CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190815124211.4gxroofqqysh2mjo@linux.intel.com>
Date:   Thu, 15 Aug 2019 15:42:11 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     ivan.lazeev@...il.com
Cc:     Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix fTPM on AMD Zen+ CPUs

On Sun, Aug 11, 2019 at 08:45:05PM +0300, ivan.lazeev@...il.com wrote:
> From: Vanya Lazeev <ivan.lazeev@...il.com>

You should have the "tpm:" tag in the beginning of short summary.

> The patch is an attempt to make fTPM on AMD Zen CPUs work.
> Bug link: https://bugzilla.kernel.org/show_bug.cgi?id=195657
> 
> The problem seems to be that tpm_crb driver doesn't expect tpm command
> and response memory regions to belong to different ACPI resources.

Should be "TPM command", not "tpm command". Please be more strict
with the spelling.

> Tested on Asrock ITX motherboard with Ryzen 2600X CPU.

EOF the long description.

> However, I don't have any other hardware to test the changes on and no
> expertise to be sure that other TPMs won't break as a result.
> Hopefully, the patch will be useful.

This should not be part of the commit message but instead should be
placed just before diffstat (below two dashes in the patch) so that
it doesn't get included into commit log.

> Signed-off-by: Vanya Lazeev <ivan.lazeev@...il.com>

You should take time and write what the commit does and why it
does what it does. That is the meat of the commit message and
your commit is completely lacking it.

I'll look at the code change once it is described appropriately.

For more information how to do commit properly I would advice
to go through the material in

https://kernelnewbies.org/FirstKernelPatch

/Jarkko