linux-kernel - Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190815125252.GC1916@kunai>
Date:   Thu, 15 Aug 2019 14:52:52 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Max Staudt <max@...as.org>
Cc:     linux-i2c@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>, linux-m68k@...r.kernel.org,
        linux-kernel@...r.kernel.org, glaubitz@...sik.fu-berlin.de
Subject: Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga


> The callback, just like getclock(), is from the existing i2c-algo-pcf,
> which I don't want to touch right now. So I'm afraid it has to stay,
> even if it returns a fixed number.

Sure. I was just thinking loud and did not expect you to do it. Maybe I
will do it once your driver is upstream.

> Touching or forking i2c-algo-pcf will be necessary in order to
> implement IRQ support, if I ever get around to it. I've wasted too
> much time on debugging IRQ support, and would rather do it another
> time, if ever ;) I've left a comment block at the start of i2c-icy.c
> for anyone interested in the gory details.

Yeah, I read it. I like such documentation. Really helpful!

> If this is okay with you, I'll send another round of patches. :)

Perfect!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)