linux-kernel - Re: [PATCH] afs: Move comments after /* fallthrough */

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12308.1565876416@warthog.procyon.org.uk>
Date:   Thu, 15 Aug 2019 14:40:16 +0100
From:   David Howells <dhowells@...hat.com>
To:     Joe Perches <joe@...ches.com>
Cc:     dhowells@...hat.com, Nathan Chancellor <natechancellor@...il.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nathan Huckleberry <nhuck@...gle.com>,
        linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] afs: Move comments after /* fallthrough */

Joe Perches <joe@...ches.com> wrote:

> Make the code a bit easier for a script to appropriately convert
> case statement blocks with /* fallthrough */ comments to a macro by
> moving comments describing the next case block to the case statement.

This doesn't sound good.  Can you give an illustration of what a resulting
case might look like?  Say taking the following as an example:

> @@ -282,10 +282,8 @@ static int afs_deliver_cb_callback(struct afs_call *call)
>  	case 0:
>  		afs_extract_to_tmp(call);
>  		call->unmarshall++;
> -
> -		/* extract the FID array and its count in two steps */
>  		/* fall through */
> -	case 1:
> +	case 1:		/* extract the FID array and its count in two steps */
>  		_debug("extract FID count");
>  		ret = afs_extract_data(call, true);
>  		if (ret < 0)

David