linux-kernel - Re: [PATCH v4 02/21] ARM: dts: imx7-colibri: disable HS400

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGgjyvFXYeGJrhT8zKoM8ACuniZUQBNqyuwimSB2UoRGo3Cj4A@mail.gmail.com>
Date:   Thu, 15 Aug 2019 13:52:39 +0000
From:   Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
To:     Philippe Schenker <philippe.schenker@...adex.com>
CC:     Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Max Krummenacher <max.krummenacher@...adex.com>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Michal Vokáč <michal.vokac@...ft.com>,
        Fabio Estevam <festevam@...il.com>,
        Stefan Agner <stefan.agner@...adex.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCH v4 02/21] ARM: dts: imx7-colibri: disable HS400

On Mon, Aug 12, 2019 at 5:23 PM Philippe Schenker
<philippe.schenker@...adex.com> wrote:
>
> From: Stefan Agner <stefan.agner@...adex.com>
>
> Force HS200 by masking bit 63 of the SDHCI capability register.
> The i.MX ESDHC driver uses SDHCI_QUIRK2_CAPS_BIT63_FOR_HS400. With
> that the stack checks bit 63 to descide whether HS400 is available.
> Using sdhci-caps-mask allows to mask bit 63. The stack then selects
> HS200 as operating mode.
>
> This prevents rare communication errors with minimal effect on
> performance:
>         sdhci-esdhc-imx 30b60000.usdhc: warning! HS400 strobe DLL
>                 status REF not lock!
>
> Signed-off-by: Stefan Agner <stefan.agner@...adex.com>
> Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@...adex.com>

> ---
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>  arch/arm/boot/dts/imx7-colibri.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
> index f1c1971f2160..f7c9ce5bed47 100644
> --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> @@ -325,6 +325,7 @@
>         vmmc-supply = <&reg_module_3v3>;
>         vqmmc-supply = <&reg_DCDC3>;
>         non-removable;
> +       sdhci-caps-mask = <0x80000000 0x0>;
>  };
>
>  &iomuxc {
> --
> 2.22.0
>


-- 
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)