linux-kernel - [PATCH 1/1] shiftfs-5.2: use copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Aug 2019 16:36:03 +0200
From:   Oleksandr Natalenko <oleksandr@...hat.com>
To:     linux-kernel@...r.kernel.org
Cc:     linux-fsdevel@...r.kernel.org,
        Christian Brauner <christian@...uner.io>,
        Seth Forshee <seth.forshee@...onical.com>,
        Stefan Bader <stefan.bader@...onical.com>,
        Kleber Sacilotto de Souza <kleber.souza@...onical.com>,
        Tyler Hicks <tyhicks@...onical.com>,
        Marcelo Henrique Cerri <marcelo.cerri@...onical.com>,
        Brad Figg <brad.figg@...onical.com>,
        James Bottomley <James.Bottomley@...senpartnership.com>
Subject: [PATCH 1/1] shiftfs-5.2: use copy_from_user() correctly

Signed-off-by: Oleksandr Natalenko <oleksandr@...hat.com>
---
 fs/shiftfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/shiftfs.c b/fs/shiftfs.c
index 49f6714e9f95..14f3764577d8 100644
--- a/fs/shiftfs.c
+++ b/fs/shiftfs.c
@@ -1526,7 +1526,7 @@ static bool in_ioctl_whitelist(int flag, unsigned long arg)
 	case BTRFS_IOC_SUBVOL_GETFLAGS:
 		return true;
 	case BTRFS_IOC_SUBVOL_SETFLAGS:
-		if (copy_from_user(&flags, arg, sizeof(flags)))
+		if (copy_from_user(&flags, argp, sizeof(flags)))
 			return false;
 
 		if (flags & ~BTRFS_SUBVOL_RDONLY)
-- 
2.22.1