linux-kernel - Re: [PATCH] clk: sunxi: Don't call clk_hw_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190815151846.DA999206C1@mail.kernel.org>
Date:   Thu, 15 Aug 2019 08:18:46 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Maxime Ripard <maxime.ripard@...tlin.com>
Cc:     Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        Chen-Yu Tsai <wens@...e.org>
Subject: Re: [PATCH] clk: sunxi: Don't call clk_hw_get_name() on a hw that isn't registered

Quoting Maxime Ripard (2019-08-15 01:01:46)
> On Wed, Aug 14, 2019 at 09:10:37PM -0700, Stephen Boyd wrote:
> > The implementation of clk_hw_get_name() relies on the clk_core
> > associated with the clk_hw pointer existing. If of_clk_hw_register()
> > fails, there isn't a clk_core created yet, so calling clk_hw_get_name()
> > here fails. Extract the name first so we can print it later.
> >
> > Fixes: 1d80c14248d6 ("clk: sunxi-ng: Add common infrastructure")
> > Cc: Maxime Ripard <maxime.ripard@...tlin.com>
> > Cc: Chen-Yu Tsai <wens@...e.org>
> > Signed-off-by: Stephen Boyd <sboyd@...nel.org>
> 
> Acked-by: Maxime Ripard <maxime.ripard@...tlin.com>
> 
> Do you want to apply it yourself, or should I merge this and send you
> a PR later?
> 

I can apply it myself. Thanks! Now to figure out the real problem...