linux-kernel - Re: [PATCH] drm/amdgpu: Apply flags after amdgpu_device_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_MqvH-jUdDUOeBM6zgwYKiv21Wuejw4sR5TwY7bJss_ow@mail.gmail.com>
Date:   Thu, 15 Aug 2019 11:28:01 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        "anthony.wong@...onical.com" <anthony.wong@...onical.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Huang, Ray" <Ray.Huang@....com>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "Koenig, Christian" <Christian.Koenig@....com>
Subject: Re: [PATCH] drm/amdgpu: Apply flags after amdgpu_device_ip_init()

On Thu, Aug 15, 2019 at 10:59 AM Kai-Heng Feng
<kai.heng.feng@...onical.com> wrote:
>
> at 21:33, Deucher, Alexander <Alexander.Deucher@....com> wrote:
>
> > Thanks for finding this!  I think the attached patch should fix the issue
> > and it's much less invasive.
>
> Yes it also fix the issue, please add by tested-by:
> Tested-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
>

Thanks!

> I took this more or less future proof approach because I think this won’t
> be the last chip that needs firmware information, which isn’t available in
> early init, to decides its flags.
>
> Yes it’s intrusive to carve out all flags from early init callbacks, but I
> don’t think it’s that ugly.

Not a bad approach, but I'd prefer to keep the power and clock gating
flags in the asic specifc code rather than in the common code.

Alex