linux-kernel - RE: [EXT] Re: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB7PR04MB4490882B1235995B82AA67CB8FAC0@DB7PR04MB4490.eurprd04.prod.outlook.com>
Date:   Thu, 15 Aug 2019 04:20:42 +0000
From:   Biwen Li <biwen.li@....com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
CC:     "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        Leo Li <leoyang.li@....com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: rtc: pcf85363/pcf85263: fix error that failed to run
 hwclock -w

> Caution: EXT Email
> 
> Hi,
> 
> On 14/08/2019 17:32:49+0800, Biwen Li wrote:
> > Issue:
> >     # hwclock -w
> >     hwclock: RTC_SET_TIME: Invalid argument
> >
> > The patch fixes error when run command hwclock -w with rtc
> > pcf85363/pcf85263
> >
> 
> Could you describe a bit more the issue and what causes it?
1. Relative patch: https://lkml.org/lkml/2019/4/3/55 , this patch will always check for unwritable registers, it will compare reg with max_register in regmap_writeable.

2. In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS is 0, max_regiter is 0x2f, then reg will be equal to 0x30, '0x30 < 0x2f' is false,so regmap_writeable will return false.
> 
> IIRC I wrote that code and it works on my pcf85363.
> 
> > Signed-off-by: Biwen Li <biwen.li@....com>
> > ---
> >  drivers/rtc/rtc-pcf85363.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c
> > index a075e77617dc..3450d615974d 100644
> > --- a/drivers/rtc/rtc-pcf85363.c
> > +++ b/drivers/rtc/rtc-pcf85363.c
> > @@ -166,7 +166,12 @@ static int pcf85363_rtc_set_time(struct device *dev,
> struct rtc_time *tm)
> >       buf[DT_YEARS] = bin2bcd(tm->tm_year % 100);
> >
> >       ret = regmap_bulk_write(pcf85363->regmap, CTRL_STOP_EN,
> > -                             tmp, sizeof(tmp));
> > +                             tmp, 2);
> > +     if (ret)
> > +             return ret;
> > +
> > +     ret = regmap_bulk_write(pcf85363->regmap, DT_100THS,
> > +                             buf, sizeof(tmp) - 2);
> >       if (ret)
> >               return ret;
> >
> > --
> > 2.17.1
> >
> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.
> com&amp;data=02%7C01%7Cbiwen.li%40nxp.com%7C8ef8fda7d05a48ef707
> 308d7209f8029%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 7013741730886353&amp;sdata=ePC651YZUzvL5ocjXAZqKT0tIZpJM01LgRNSa
> 7i7wLE%3D&amp;reserved=0