[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190815.123430.831231953098536795.davem@davemloft.net>
Date: Thu, 15 Aug 2019 12:34:30 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: wenwen@...uga.edu
Cc: rfontana@...hat.com, allison@...utok.net, alexios.zavras@...el.com,
gregkh@...uxfoundation.org, tglx@...utronix.de,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: pch_gbe: Fix memory leaks
From: Wenwen Wang <wenwen@...uga.edu>
Date: Tue, 13 Aug 2019 20:33:45 -0500
> In pch_gbe_set_ringparam(), if netif_running() returns false, 'tx_old' and
> 'rx_old' are not deallocated, leading to memory leaks. To fix this issue,
> move the free statements after the if branch.
>
> Signed-off-by: Wenwen Wang <wenwen@...uga.edu>
Why would they be "deallocated"? They are still assigned to
adapter->tx_ring and adapter->rx_ring.
Powered by blists - more mailing lists