linux-kernel - Re: [PATCH] iio: dac: ad5380: fix incorrect assignment to val

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Aug 2019 06:16:26 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     "Popa, Stefan Serban" <StefanSerban.Popa@...log.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "knaack.h@....de" <knaack.h@....de>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: dac: ad5380: fix incorrect assignment to val

On Thu, 2019-08-15 at 12:58 +0100, Colin King wrote:
> [External]
> 

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@...log.com>

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently the pointer val is being incorrectly incremented
> instead of the value pointed to by val. Fix this by adding
> in the missing * indirection operator.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/iio/dac/ad5380.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
> index 4335214800d2..2ebe08326048 100644
> --- a/drivers/iio/dac/ad5380.c
> +++ b/drivers/iio/dac/ad5380.c
> @@ -220,7 +220,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev,
>  		if (ret)
>  			return ret;
>  		*val >>= chan->scan_type.shift;
> -		val -= (1 << chan->scan_type.realbits) / 2;
> +		*val -= (1 << chan->scan_type.realbits) / 2;
>  		return IIO_VAL_INT;
>  	case IIO_CHAN_INFO_SCALE:
>  		*val = 2 * st->vref;