linux-kernel - Re: [PATCH] csky: Fixup ioremap function losing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190816070348.GA13766@infradead.org>
Date:   Fri, 16 Aug 2019 00:03:48 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     guoren@...nel.org
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org, linux-csky@...r.kernel.org,
        zhang_jian5@...uatech.com, Guo Ren <ren_guo@...ky.com>,
        Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH] csky: Fixup ioremap function losing

On Thu, Aug 15, 2019 at 07:28:57PM +0800, guoren@...nel.org wrote:
> From: Guo Ren <ren_guo@...ky.com>
> 
> Implement the following apis to meet usage in different scenarios.
> 
>  - ioremap          (NonCache + StrongOrder)
>  - ioremap_nocache  (NonCache + StrongOrder)
>  - ioremap_wc       (NonCache + WeakOrder  )
>  - ioremap_cache    (   Cache + WeakOrder  )
> 
> Also change flag VM_ALLOC to VM_IOREMAP in get_vm_area_caller.

Looks generally fine, but two comments:

 - do you have a need for ioremap_cache?  We are generally try to
   phase it out in favour of memremap, and it is generally only used
   by arch specific code.
 - I have a big series pending to clean up the mess with our
   ioremap_* functions, including adding a generic implementation
   that csky should be able to use.  Unless this patch is urgent it
   might make sense to rebase it on top.  Here is my current tree, I
   plan to post it soon:

	http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/generic-ioremap