linux-kernel - 答复: [PATCH] ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0B80F9D4116B2F4484E7279D5A66984F7C0325@dggemi524-mbx.china.huawei.com>
Date:   Fri, 16 Aug 2019 08:00:42 +0000
From:   chengzhihao <chengzhihao1@...wei.com>
To:     Richard Weinberger <richard.weinberger@...il.com>
CC:     Richard Weinberger <richard@....at>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Artem Bityutskiy <dedekind1@...il.com>,
        "zhangyi (F)" <yi.zhang@...wei.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH] ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps

>  ubifs_assert(c, p < c->gap_lebs + c->lst.idx_lebs);

I've done 50 problem reproduces on different flash devices and made sure that the assertion was not triggered. See record.txt for details.

-----邮件原件-----
发件人: chengzhihao 
发送时间: 2019年8月14日 9:20
收件人: 'Richard Weinberger' <richard.weinberger@...il.com>
抄送: Richard Weinberger <richard@....at>; Sascha Hauer <s.hauer@...gutronix.de>; Artem Bityutskiy <dedekind1@...il.com>; zhangyi (F) <yi.zhang@...wei.com>; linux-mtd@...ts.infradead.org; LKML <linux-kernel@...r.kernel.org>
主题: 答复: [PATCH] ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps

Sure, I'll do more tests on different machines to check the assertion. I'm trying to understand when this assertion will be triggered. Although I haven't found this assertion be triggered so far in several tests on x86_64(qemu).

-----邮件原件-----
发件人: Richard Weinberger [mailto:richard.weinberger@...il.com] 
发送时间: 2019年8月14日 5:44
收件人: chengzhihao <chengzhihao1@...wei.com>
抄送: Richard Weinberger <richard@....at>; Sascha Hauer <s.hauer@...gutronix.de>; Artem Bityutskiy <dedekind1@...il.com>; zhangyi (F) <yi.zhang@...wei.com>; linux-mtd@...ts.infradead.org; LKML <linux-kernel@...r.kernel.org>
主题: Re: [PATCH] ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps

On Tue, Jul 30, 2019 at 3:21 AM chengzhihao <chengzhihao1@...wei.com> wrote:
>
> OK, that's fine, and I will continue to understand more implementation code related to this part.

I think we can go with the realloc() approach for now.
Can you please check whether the assert() triggers?

-- 
Thanks,
//richard

View attachment "record.txt" of type "text/plain" (8397 bytes)