[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190816081514.GU6133@paasikivi.fi.intel.com>
Date: Fri, 16 Aug 2019 11:15:14 +0300
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Hugues Fruchet <hugues.fruchet@...com>
Cc: Alexandre Torgue <alexandre.torgue@...com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
Benjamin Gaignard <benjamin.gaignard@...aro.org>,
Yannick Fertre <yannick.fertre@...com>,
Philippe CORNU <philippe.cornu@...com>,
Mickael GUENE <mickael.guene@...com>
Subject: Re: [PATCH v6 2/4] media: stm32-dcmi: trace the supported
fourcc/mbus_code
Hi Hugues,
On Wed, Aug 14, 2019 at 03:48:51PM +0200, Hugues Fruchet wrote:
> Add a trace of the set of supported fourcc/mbus_code which
> intersect between DCMI and source sub-device.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@...com>
> ---
> drivers/media/platform/stm32/stm32-dcmi.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
> index b462f71..18acecf 100644
> --- a/drivers/media/platform/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
> @@ -1447,12 +1447,20 @@ static int dcmi_formats_init(struct stm32_dcmi *dcmi)
> /* Code supported, have we got this fourcc yet? */
> for (j = 0; j < num_fmts; j++)
> if (sd_fmts[j]->fourcc ==
> - dcmi_formats[i].fourcc)
> + dcmi_formats[i].fourcc) {
> /* Already available */
> + dev_dbg(dcmi->dev, "Skipping fourcc/code: %4.4s/0x%x\n",
> + (char *)&sd_fmts[j]->fourcc,
> + mbus_code.code);
> break;
> - if (j == num_fmts)
> + }
> + if (j == num_fmts) {
> /* New */
> sd_fmts[num_fmts++] = dcmi_formats + i;
> + dev_dbg(dcmi->dev, "Supported fourcc/code: %4.4s/0x%x\n",
Over 80 characters per line.
> + (char *)&sd_fmts[num_fmts - 1]->fourcc,
> + sd_fmts[num_fmts - 1]->mbus_code);
> + }
> }
> mbus_code.index++;
> }
--
Regards,
Sakari Ailus
sakari.ailus@...ux.intel.com
Powered by blists - more mailing lists